[PATCH] fix ptr_ret.cocci warnings
From: Julia Lawall
Date: Mon May 15 2017 - 06:52:23 EST
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
CC: Stephan Müller <smueller@xxxxxxxxxx>
Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx>
Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
---
Not very important, but the code can be a little simpler.
lrng_base.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/char/lrng_base.c
+++ b/drivers/char/lrng_base.c
@@ -1523,10 +1523,7 @@ static int lrng_alloc(void)
lrng_init_rng(key, sizeof(key));
lrng_pool.lrng_hash = lrng_hash_alloc(LRNG_HASH_NAME, key, sizeof(key));
memzero_explicit(key, sizeof(key));
- if (IS_ERR(lrng_pool.lrng_hash))
- return PTR_ERR(lrng_pool.lrng_hash);
-
- return 0;
+ return PTR_ERR_OR_ZERO(lrng_pool.lrng_hash);
}
/************************** LRNG kernel interfaces ***************************/