Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems

[Andy Shevchenko]

On Mon, 2017-05-15 at 14:01 +0300, Mika Westerberg wrote:
> It turns out there are quite many Chromebooks out there that have the
> same keyboard issue than Acer Chromebook. All of them are based on
> Intel_Strago reference and report their DMI_PRODUCT_FAMILY as
> "Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are
> exceptions
> for which we add separate entries).
> 
> Instead of adding each machine to the quirk table, we use
> DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the
> machines out there currently.
> 
> 

> +		.ident = "Intel_Strago based Chromebooks",

> +		.ident = "Cyan Chromebook",

> +		.ident = "Samsung Chromebook 3",

I would do something like below (though I'm fine with current as well).

	.ident = "Intel_Strago based Chromebooks (All models)",
	.ident = "Intel_Strago based Chromebooks (Cyan)",
	.ident = "Samsung Chromebook 3 (Celes)",

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy