Re: [PATCH v8 1/5] skbuff: return -EMSGSIZE in skb_to_sgvec to prevent overflow

From: David Howells
Date: Mon May 15 2017 - 09:12:59 EST

Next message: Vlastimil Babka: "[PATCH] sched/numa: use down_read_trylock for mmap_sem"
Previous message: Eric Dumazet: "Re: [PATCH] kmod: don't load module unless req process has CAP_SYS_MODULE"
In reply to: David Howells: "Re: [PATCH v8 3/5] rxrpc: check return value of skb_to_sgvec always"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:

> +int skb_to_sgvec(struct sk_buff *skb, struct scatterlist *sg, int offset, int len)
> ...
> -int skb_to_sgvec(struct sk_buff *skb, struct scatterlist *sg, int offset, int len)

Is there a reason you moved skb_to_sgvec() in the file rather than just moving
the comment to it (since you moved the comment anyway)?

David

Next message: Vlastimil Babka: "[PATCH] sched/numa: use down_read_trylock for mmap_sem"
Previous message: Eric Dumazet: "Re: [PATCH] kmod: don't load module unless req process has CAP_SYS_MODULE"
In reply to: David Howells: "Re: [PATCH v8 3/5] rxrpc: check return value of skb_to_sgvec always"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]