Re: [PATCH] kbuild: skip header install/check for right under uapi directories

From: Dan Williams
Date: Tue May 16 2017 - 01:03:23 EST


On Mon, May 15, 2017 at 9:35 PM, Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
> Since commit 61562f981e92 ("uapi: export all arch specifics
> directories"), "make INSTALL_HDR_PATH=${root}/usr headers_install"
> deletes standard glibc headers and others in ${root}/usr/include.
>
> The cause of the issue is that headers_install now starts descending
> from arch/$(hdr-arch)/include/uapi with ${root}/usr/include for its
> destination when installing asm headers. So, headers already there
> are assumed to be unwanted.
>
> When headers_install starts descending from include/uapi with
> ${root}/usr/include for its destination, it works around the problem
> by creating an dummy destination ${root}/usr/include/uapi, but this
> is tricky.
>
> To fix the problem in a clean way is to skip header install/check in
> include/uapi or arch/$(hdr-arch)/include/uapi. A good side-effect
> is the empty destination ${root}/usr/include/uapi will go away.
>
> Fixes: 61562f981e92 ("uapi: export all arch specifics directories")
> Reported-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

Works for me.

Tested-by: Dan Williams <dan.j.williams@xxxxxxxxx>