Re: [PATCH] [iov_iter] use memmove() when copying to/from user page

From: Al Viro
Date: Tue May 16 2017 - 17:33:56 EST


On Tue, May 16, 2017 at 02:01:51PM -0700, Dmitry Vyukov wrote:

> > In that case your patch does not suffice. Overlapping move _forwards_ still
> > yields unexpected results, doesn't it?
>
> Why? memmove can move both ways. Do we need to change more memcpy's to
> memmove's?

Because it's not going to be *one* call of memcpy() or memmove(). It's
one per page.