Re: linux-next: build warning after merge of the overlayfs tree

From: Amir Goldstein
Date: Wed May 17 2017 - 01:02:13 EST


On Wed, May 17, 2017 at 3:19 AM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> Hi Miklos,
>
> After merging the overlayfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/overlayfs/dir.c: In function 'ovl_rename':
> fs/overlayfs/dir.c:1060:2: warning: 'newdentry' may be used uninitialized in this function [-Wmaybe-uninitialized]
> dput(newdentry);
> ^
> fs/overlayfs/dir.c:1062:2: warning: 'olddentry' may be used uninitialized in this function [-Wmaybe-uninitialized]
> dput(olddentry);
> ^
>
> Introduced by commit
>
> 02cac3227a28 ("ovl: mark upper dir with type origin entries "impure"")
>

Posted a fix for that ("ovl: fix wrong error handling of ovl_set_impure()")

Thanks!