Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

[Guenter Roeck]

On 05/16/2017 09:39 PM, Ye Xiaolong wrote:
> On 05/17, Chris Packham wrote:
> > On 17/05/17 15:09, Ye Xiaolong wrote:
> > > On 05/16, Chris Packham wrote:
> > > > On 16/05/17 20:23, kbuild test robot wrote:
> > > > > Hi Chris,
> > > > >
> > > > > [auto build test ERROR on hwmon/hwmon-next]
> > > > > [also build test ERROR on v4.12-rc1 next-20170516]
> > > > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > > > >
> > > > > url:    https://github.com/0day-ci/linux/commits/Chris-Packham/hwmon-adt7475-fan-stall-prevention/20170515-093530
> > > > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
> > > > > config: x86_64-rhel (attached as .config)
> > > > > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > > > > reproduce:
> > > > >         # save the attached .config to linux build tree
> > > > >         make ARCH=x86_64
> > > > >
> > > > > All errors (new ones prefixed by >>):
> > > > >
> > > > >    drivers/hwmon/adt7475.c: In function 'set_temp_st':
> > > > > > > drivers/hwmon/adt7475.c:622:9: error: implicit declaration of function 'find_closest_descending' [-Werror=implicit-function-declaration]
> > > > >       val = find_closest_descending(val, ad7475_st_map,
> > > > >             ^~~~~~~~~~~~~~~~~~~~~~~
> > > > >    cc1: some warnings being treated as errors
> > > > >
> > > > > vim +/find_closest_descending +622 drivers/hwmon/adt7475.c
> > > > >
> > > > >    616			shift = 4;
> > > > >    617			idx = 1;
> > > > >    618			break;
> > > > >    619		}
> > > > >    620	
> > > > >    621		if (val > 0) {
> > > > >  > 622			val = find_closest_descending(val, ad7475_st_map,
> > > > >    623						      ARRAY_SIZE(ad7475_st_map));
> > > > >    624			val |= 0x8;
> > > > >    625		}
> > > > >
> > > > > ---
> > > > > 0-DAY kernel test infrastructure                Open Source Technology Center
> > > > > https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> > > >
> > > > I'm not sure how this is failing. find_closest_descending() is a macro
> > > > defined in linux/util_macros.h which is explicitly included in
> > > > drivers/hwmon/adt7475.c. Aside from the include guards there's nothing
> > > > conditional about it.
> > >
> > > Hi,
> > >
> > > 0day bot applied your patchset on top of commit 6eaaea1 ("hwmon: (pmbus) Add client driver for IR35221"),
> > > is it wrong or you have some prerequisite patches?
>
> Thanks for the info, seems we need to improve the kbuild bot by pulling the
> latest tree before applying new patches.

No worries. I don't mind the occasional false positive. Better a false positive than a missed bug.

Guenter

> Thanks,
> Xiaolong
> > >
> >
> > Looks like it's missing
> > https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=bbb4dd0ff
> > which was part of the series but was applied after v3 so I didn't send
> > it out with v4.