Re: [PATCH 0/3] xen/blkback: several fixes of resource management

From: Steven Haigh
Date: Wed May 17 2017 - 22:04:25 EST


On 2017-05-16 16:23, Juergen Gross wrote:
Destroying a Xen guest domain while it was doing I/Os via xen-blkback
leaked several resources, including references of the guest's memory
pages.

This patch series addresses those leaks by correcting usage of
reference counts and the sequence when to free which resource.

The series applies on top of commit 2d4456c73a487abe ("block:
xen-blkback: add null check to avoid null pointer dereference") in
Jens Axboe's tree kernel/git/axboe/linux-block.git

Juergen Gross (3):
xen/blkback: fix disconnect while I/Os in flight
xen/blkback: don't free be structure too early
xen/blkback: don't use xen_blkif_get() in xen-blkback kthread

drivers/block/xen-blkback/blkback.c | 3 ---
drivers/block/xen-blkback/common.h | 1 +
drivers/block/xen-blkback/xenbus.c | 15 ++++++++-------
3 files changed, 9 insertions(+), 10 deletions(-)

Tested-by: Steven Haigh <netwiz@xxxxxxxxx>

I've had a report that a new message is logged on destroy sometimes:
vif vif-1-0 vif1.0: Guest Rx stalled

This may be a different issue - however the main fix of this patch set is fully functional.

--
Steven Haigh

Email: netwiz@xxxxxxxxx
Web: https://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897