Re: [RESEND PATCH v3] sched/deadline: Remove unnecessary condition in push_dl_task()
From: Juri Lelli
Date: Thu May 18 2017 - 04:12:32 EST
On 18/05/17 11:00, Byungchul Park wrote:
> On Fri, May 12, 2017 at 10:05:59AM +0900, Byungchul Park wrote:
> > pick_next_pushable_dl_task(rq) has BUG_ON(rq->cpu != task_cpu(task))
> > when it returns a task other than NULL, which means that task_cpu(task)
> > must be rq->cpu. So if task == next_task, then task_cpu(next_task) must
> > be rq->cpu as well. Remove the redundant condition and make code simpler.
> > By this patch, unnecessary one branch and two LOAD operations in 'if'
> > statement can be avoided.
> +cc rostedt@xxxxxxxxxxx
> +cc juri.lelli@xxxxxxx
> +cc bristot@xxxxxxxxxx
> > Signed-off-by: Byungchul Park <byungchul.park@xxxxxxx>
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> > Reviewed-by: Juri Lelli <juri.lelli@xxxxxxx>
It looked, and still looks, good to me. :)