Re: [PATCH] staging: iio: light: Replace symbolic permissions as per coding style

[Greg KH]

On Thu, May 18, 2017 at 02:06:29PM +0530, surenderpolsani@xxxxxxxxx wrote:
> From: Surender Polsani <surenderpolsani@xxxxxxxxx>
> 
> Fixed the following checkpatch.pl warnings:
> octal permissions are more preferable than symbolic permissions
> 
> Signed-off-by: Surender Polsani <surenderpolsani@xxxxxxxxx>
> ---
>  drivers/staging/iio/light/tsl2x7x_core.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
> index af3910b..c63fe6a 100644
> --- a/drivers/staging/iio/light/tsl2x7x_core.c
> +++ b/drivers/staging/iio/light/tsl2x7x_core.c
> @@ -1498,34 +1498,34 @@ static int tsl2x7x_write_raw(struct iio_dev *indio_dev,
>  	return 0;
>  }
>  
> -static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR,
> +static DEVICE_ATTR(power_state, 0644,
>  		tsl2x7x_power_state_show, tsl2x7x_power_state_store);

How about using DEVICE_ATTR_RW() and DEVICE_ATTR_RO() instead?

thanks,

greg k-h