Re: [PATCH linux-next v2 1/1] spi: imx: dynamic burst length adjust for PIO mode

From: Leonard Crestez
Date: Thu May 18 2017 - 05:30:08 EST


On Wed, 2017-05-17 at 18:50 -0700, Jiada Wang wrote:
> Hello Leonard
>
> Thanks for the report, can you help to check if the following changeÂ
> address the issue?
>
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index 782045f..19b30cf 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -288,6 +288,9 @@ static void spi_imx_u32_swap_u8(struct spi_transferÂ
> *transfer, u32 *buf)
> Â {
> ÂÂÂÂÂÂÂÂÂint i;
>
> +ÂÂÂÂÂÂÂif (!buf)
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturn;
> +
> ÂÂÂÂÂÂÂÂÂfor (i = 0; i < transfer->len / 4; i++)
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ*(buf + i) = cpu_to_be32(*(buf + i));
> Â }
> @@ -296,6 +299,9 @@ static void spi_imx_u32_swap_u16(struct spi_transferÂ
> *transfer, u32 *buf)
> Â {
> ÂÂÂÂÂÂÂÂÂint i;
>
> +ÂÂÂÂÂÂÂif (!buf)
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturn;
> +
> ÂÂÂÂÂÂÂÂÂfor (i = 0; i < transfer->len / 4; i++) {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu16 *temp = (u16 *)buf;
>

Yes, this does seem to fix it.