Re: [PATCH] arm64: cpufeature: check translation granule size based on kernel config

From: Will Deacon
Date: Thu May 18 2017 - 11:13:34 EST


On Thu, May 18, 2017 at 03:24:15PM +0100, Mark Rutland wrote:
> On Thu, May 18, 2017 at 09:02:50PM +0800, Leo Yan wrote:
> > On Thu, May 18, 2017 at 01:41:15PM +0100, Mark Rutland wrote:
> > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> > > index 94b8f7f..1f53314 100644
> > > --- a/arch/arm64/kernel/cpufeature.c
> > > +++ b/arch/arm64/kernel/cpufeature.c
> > > @@ -639,8 +639,8 @@ void update_cpu_features(int cpu,
> > > * Mismatched CPU features are a recipe for disaster. Don't even
> > > * pretend to support them.
> > > */
> > > - WARN_TAINT_ONCE(taint, TAINT_CPU_OUT_OF_SPEC,
> > > - "Unsupported CPU feature variation.\n");
> > > + pr_warn_once("Unsupported CPU feature variation detected.\n");
> > > + add_taint(TAINT_CPU_OUT_OF_SPEC);
> >
> > Should be add_taint(TAINT_CPU_OUT_OF_SPEC, LOCKDEP_STILL_OK)?
>
> Whoops; yes.

I've picked this up with the fix above.

Will