Re: [PATCH 5/7] perf header: use struct feat_fd for process and read
From: David Carrillo-Cisneros
Date: Thu May 18 2017 - 14:03:01 EST
On Thu, May 18, 2017 at 9:13 AM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> On Wed, May 17, 2017 at 09:16:00PM -0700, David Carrillo-Cisneros wrote:
>> As preparation for using header records in pipe mode, replace
>> int fd with struct feat_fd fd in process and read functions for
>> all header record types.
>> To reduce the boiler plate, define and use the FEAT_PROCESS_STR_FUN
>> macro for the common case of header records that are a simple string.
> please separate those changes, AFAICS it's following:
> - using feat_fd in read functions
> - reworking do_read_string function
> - replacing readn with new do_read* functions
> - adding FEAT_PROCESS_STR_FUN