Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode

[David Carrillo-Cisneros]

On Thu, May 18, 2017 at 9:13 AM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> On Wed, May 17, 2017 at 09:16:02PM -0700, David Carrillo-Cisneros wrote:
>
> SNIP
>
>>
>> @@ -2107,42 +2109,80 @@ struct feature_ops {
>>       int (*process)(struct feat_fd *fd, void *data);
>>       const char *name;
>>       bool full_only;
>> +     int record_type;
>>  };
>>
>> -#define FEAT_OPA(n, func) \
>> -     [n] = { .name = #n, .write = write_##func, .print = print_##func }
>> -#define FEAT_OPP(n, func) \
>> -     [n] = { .name = #n, .write = write_##func, .print = print_##func, \
>> -             .process = process_##func }
>> -#define FEAT_OPF(n, func) \
>> -     [n] = { .name = #n, .write = write_##func, .print = print_##func, \
>> -             .process = process_##func, .full_only = true }
>> +#define FEAT_OPP(n, func, __full_only) \
>> +     [HEADER_##n] = {                                        \
>> +             .name = __stringify(HEADER_##n),                \
>> +             .write = write_##func,                          \
>> +             .print = print_##func,                          \
>> +             .full_only = __full_only,                       \
>> +             .process = process_##func,                      \
>> +             .record_type = PERF_RECORD_HEADER_##n           \
>> +     }
>> +
>> +#define FEAT_OPN(n, func, __full_only) \
>> +     [HEADER_##n] = {                                        \
>> +             .name = __stringify(HEADER_##n),                \
>> +             .write = write_##func,                          \
>> +             .print = print_##func,                          \
>> +             .full_only = __full_only,                       \
>> +             .process = process_##func                       \
>> +     }
>
> you're adding record_type, which should not be a reason
> to rename FEAT_* macros.. please do that in the separate
> patch and state reason in changelog

will do