Re: [PATCH] ring-buffer: Remove unused function __rb_data_page_index()

From: Doug Anderson
Date: Thu May 18 2017 - 15:48:50 EST


On Thu, May 18, 2017 at 12:46 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Thu, 18 May 2017 12:40:02 -0700
> Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
>> Hi,
>> This appears to have been introduced in 2009 by commit afbab76a62b6
>> ("ring-buffer: have read page swap increment counter with page
>> entries"), which removed the user of the function but not the function
>> itself. If folks were so inclined, this could be picked back to
>> linux-stable, but I'm not sure it's worth it.
> It doesn't do anything but waste some disk space in the source
> repository. It's a static inline function, which means it's not created
> unless something calls it.
> Thus, not worth the stable churn.

Yup, that's sane. I guess not much chance of someone trying to get
clang to run w/ no warnings by just picking stable patches. ;-)