Re: [PATCH] usb: chipidea: debug: check before accessing ci_role

[Peter Chen]

On Thu, May 18, 2017 at 04:14:14PM +0200, Michael Thalmeier wrote:
> ci_role BUGs when the role is >= CI_ROLE_END.
> 
> Signed-off-by: Michael Thalmeier <michael.thalmeier@xxxxxxx>
> ---
>  drivers/usb/chipidea/debug.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
> index 6d23eed..1c31e8a 100644
> --- a/drivers/usb/chipidea/debug.c
> +++ b/drivers/usb/chipidea/debug.c
> @@ -294,7 +294,8 @@ static int ci_role_show(struct seq_file *s, void *data)
>  {
>  	struct ci_hdrc *ci = s->private;
>  
> -	seq_printf(s, "%s\n", ci_role(ci)->name);
> +	if (ci->role != CI_ROLE_END)
> +		seq_printf(s, "%s\n", ci_role(ci)->name);
>  
>  	return 0;
>  }

By the way, how can you trigger this issue?
Do you mind sending another patch to fix the same issue for ci_role_show
at core.c?

-- 

Best Regards,
Peter Chen