Re: [PATCH 2/3] livepatch: send a fake signal to all blocking tasks

From: Miroslav Benes
Date: Fri May 19 2017 - 03:51:55 EST



> > If not, we get back to exit_to_usermode_loop() and TIF_PATCH_PENDING is
> > cleared. Yes, it is true that TIF_SIGPENDING is still set and we get to
> > do_signal() once more. But for the last time.
>
> Yes, slightly sub-optimal but not really wrong and you can swap
> do_signal() and klp_update_patch_state().

Ok. I'll add it to v2.

> > If the syscall is restarted, it may be different. I have to think about
> > this one. But...
>
> Afaics, there are no problems.
>
>
> In short. Thanks for correcting me and sorry for noise!

Thanks for the review, Oleg. Much appreciated.

Miroslav