Re: [PATCH 4/4] Hyper-V vPCI: use vPCI protocol version 1.2

From: Stephen Hemminger
Date: Fri May 19 2017 - 11:21:46 EST


On Fri, 19 May 2017 14:27:01 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> > /*
> > + * HV_VP_SET available
> > + */
> > +#define HV_X64_EX_PROCESSOR_MASKS_RECOMMENDED (1 << 11)
>
> Use BIT(11). I thought checkpatch.pl complains about this but I guess
> that's only with the --strict option.

Since all the other field values are encoded as shifts, doing something
different for this field stands out. Therefore just use (1 << 11)
or change all the previous values using BIT() macro