Re: [PATCH v3] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI

[Robert Foss]

On 2017-05-18 05:49 AM, Ville Syrjälä wrote:
> On Wed, May 17, 2017 at 09:39:11PM -0400, Robert Foss wrote:
> > +/*
> > + * DRM_MODE_REFLECT_<axis>
> > + *
> > + * Signals that the contents of a drm plane has been reflected in
> > + * the <axis> axis.
>
> Still vague.

Ack, I'll add some verbiage.

> Also you didn't respond to my comment about the use of past tense.

Fixed in v4.


Rob.

> > + *
> > + * This define is provided as a convenience, looking up the property id
> > + * using the name->prop id lookup is the preferred method.
> > + */
> > +#define DRM_MODE_REFLECT_X      (1<<4)
> > +#define DRM_MODE_REFLECT_Y      (1<<5)
> > +
> > +/*
> > + * DRM_MODE_REFLECT_MASK
> > + *
> > + * Bitmask used to look for drm plane reflections.
> > + */
> > +#define DRM_MODE_REFLECT_MASK (\
> > +		DRM_MODE_REFLECT_X | \
> > +		DRM_MODE_REFLECT_Y)
> > +
> > +
> >   struct drm_mode_modeinfo {
> >   	__u32 clock;
> >   	__u16 hdisplay;
> > --
> > 2.11.0.453.g787f75f05