Re: [PATCH] Use ctlr directly in rdac_failover_get()

From: Bart Van Assche
Date: Fri May 19 2017 - 18:23:47 EST


On Fri, 2017-05-19 at 14:06 +0200, Artem Savkov wrote:
> rdac_failover_get references struct rdac_controller as
> ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being
> inefficient this also introduces a null-pointer dereference as
> send_mode_select() sets ctlr->ms_sdev to NULL before calling
> rdac_failover_get():
>
> [ ... ]
> Signed-off-by: Artem Savkov <asavkov@xxxxxxxxxx>

Hello Artem,

Although this patch looks fine to me, please consider adding the "Fixes:" and
"Cc: <stable@xxxxxxxxxxxxxxx>" tags.

Bart.