Re: [PATCH v2 00/18] ARM64: meson: DT cleanups

From: Andreas FÃrber
Date: Sat May 20 2017 - 09:16:41 EST


Hi Kevin,

Am 18.05.2017 um 00:34 schrieb Kevin Hilman:
> Andreas FÃrber <afaerber@xxxxxxx> writes:
>> Am 15.05.2017 um 10:16 schrieb Neil Armstrong:
>>> It's not perfect, but now it's done, live with it, this has already been discussed.
>>
>> No.
>>
>> Copy&pasting your comment N times does not make it any more valid. My
>> files, my rules - I insist on vega-s95, gxbb and gx, which you guys
>> refactored out from my gxbb, to be tidy.
>
> hmm, "my files, my rules, ... my gxbb"
>
> Very interesting perspective, but sorry, these do not belong to you.
> They belong to the kernel community. You can insist if you like, but we
> do not make decisions just because someone says "mine". Again, the
> confrontaional tone is not helpful to the dialogue.

We can certainly argue who started which tone here. From my perspective
I kindly asked Jerome to fix his node order on IRC, he said okay, but
neither he nor any of you ever sent such patches. (This was back when we
had an actual mismerge.) Weeks later I grudgingly sent the v1 cleanup
series myself, but instead of thanking me for doing "your" work, I was
greeted with unfriendly opposition and - yes, frustratingly is a word
here - put my efforts elsewhere. Neil's actions - who is neither author
nor maintainer here - of copying an opinionated personal and partially
wrong statement into a dozen neutral patches was highly offensive to me
and further escalated things. Stating his opinion, which he is welcome
to do, once would has sufficed.

Also what this "my" is about - and that should give you thought - is
that you guys added nodes to the Vega .dtsi file without adding any
BayLibre or other copyright. To someone downloading a tarball without
git history, that makes it look as if _I_ misordered those nodes in the
file that carries my name. So I would kindly suggest that you add your
copyright when making non-trivial additions.

Thanks,
Andreas

--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Felix ImendÃrffer, Jane Smithard, Graham Norton
HRB 21284 (AG NÃrnberg)