Re: [PATCH 1/1] xilinx ps uart: Adding a kernel parameter for the number of xilinx ps uarts
From: Alan Cox
Date: Sat May 20 2017 - 12:21:36 EST
On Fri, 19 May 2017 20:21:54 -0600
Sam Povilus <kernel.development@xxxxxxxx> wrote:
> The number of xilinx ps uart should be set by a kernel parameter instead of
> using a #define. This allows the user to set the number of xilinx ps uart
> using only kconfig and not modifying kernel source.
>
> The ps uart is used in Xilnx Zynq chips usually in quantities maxing at
> two, but there may be other chips that use more in the future or that I
> don't know about.
If it maxes at two then just set it to two. If in in future it maxes at
lots then when it's going to happen change the code to do dynamic
allocation and test it versus actual hardware.
Otherwise you break some of the basic ideas of having one kernel for many
systems.
Alan