Re: [PATCH] lpfc: nvmet_fc: fix format string
From: Joe Perches
Date: Sat May 20 2017 - 20:44:50 EST
On Sat, 2017-05-20 at 21:10 +0200, Arnd Bergmann wrote:
> On Sat, May 20, 2017 at 12:28 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Fri, 2017-05-19 at 10:04 +0200, Arnd Bergmann wrote:
> > > The lpfc_nvmeio_data() tracing helper always takes a format string and
> > > three additional arguments.
> >
> > No it doesn't. It takes a format and arguments.
> >
> > I don't disagree with the patch, just the characterization
> > of the lpfc_mvmeio_data call in the commit message.
>
> I think my description is correct, it's just not obvious from
> reading the code until you also look at the lpfc_debugfs_nvme_trc
> prototype:
OK, but more that's a mismatch between a function and its
arguments and a different called function within it.