Re: [patch v2 1/6] tty: export tty_open_by_driver
From: Greg Kroah-Hartman
Date: Sun May 21 2017 - 03:44:13 EST
On Sat, May 20, 2017 at 11:09:02PM -0700, Christoph Hellwig wrote:
> On Mon, May 15, 2017 at 06:45:32PM +0100, Okash Khawaja wrote:
> > This exports tty_open_by_driver so that it can be called from other places inside the kernel. The checks for null file pointer are based on Alan Cox's patch here: http://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1215095.html. Description below is quoted from it:
>
> Any non-staging users? Please don't add new APIs with proper in-kernel
> users (and staging doesn't count for that).
I'll give the speakup code a pass here, as they are trying to get this
cleaned up properly and moved into the correct location. It's almost
ready, with this and the serdev interface, it should be pretty close...
thanks,
greg k-h