Re: gpio-exar: Why filtering out Commtech devices?

From: Sudip Mukherjee
Date: Sun May 21 2017 - 16:09:15 EST


Hi Jan,

On 21/05/17 12:46, Jan Kiszka wrote:
Hi Sudip,

why do we carry

if (pcidev->vendor != PCI_VENDOR_ID_EXAR)
return -ENODEV;

in gpio_exar_probe? This effectively prevents that

EXAR_DEVICE(COMMTECH, COMMTECH_4222PCIE, pbn_exar_XR17V35x),
EXAR_DEVICE(COMMTECH, COMMTECH_4224PCIE, pbn_exar_XR17V35x),
EXAR_DEVICE(COMMTECH, COMMTECH_4228PCIE, pbn_exar_XR17V35x),

gain GPIO support. Do those devices lack access to the pins? Or can we
drop the filter. I don't have access to those devices, just wondering
because the code is not explaining the reason.

Same here. I do not have these devices and have no idea if they support the gpio pins or not.

Adding Matt Schulte in the Cc list, maybe he can comment.


--
Regards
Sudip