Re: [PATCH] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform

[Lee Jones]

On Fri, 19 May 2017, Jan Kiszka wrote:

> On 2017-05-12 10:12, Lee Jones wrote:
> > On Tue, 09 May 2017, Andy Shevchenko wrote:
> > 
> >> On Tue, 2017-05-09 at 06:40 +0200, Jan Kiszka wrote:
> >>> The SIMATIC IOT2000 is derived from the Galileo Gen2 board and shares
> >>> its I2C frequency.
> >>>
> >>> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> >>
> >>> Signed-off-by: Sascha Weisenberger <sascha.weisenberger@xxxxxxxxxxx>
> >>
> >> Hmm... I thought that SoB chain goes from first author to last. (Or in
> >> case of maintainer / submitter their SoB goes at the end, which is
> >> apparently not the case here).
> > 
> > Yes, that's correct.  I will switch them when I apply the patch.
> 
> Apparently, the patch is not yet in mfd-next, so let me retract it: I
> just realized we should rather do an exact name/asset-tags match here as
> well (like for exar and stmmac).

Consider it done.

> Moreover, I'd like to rework the DMI matching along Andy's suggestion
> and use native matching methods (dmi_system_id table) instead of the
> current open-code one. Patches will follow soon.
> 
> Jan
> 
> > 
> >> Other than above
> >>
> >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > 
> >>>
> >>> ---
> >>>  drivers/mfd/intel_quark_i2c_gpio.c | 4 ++++
> >>>  1 file changed, 4 insertions(+)
> >>>
> >>> diff --git a/drivers/mfd/intel_quark_i2c_gpio.c
> >>> b/drivers/mfd/intel_quark_i2c_gpio.c
> >>> index 7946d6e38b87..98dddf2831ad 100644
> >>> --- a/drivers/mfd/intel_quark_i2c_gpio.c
> >>> +++ b/drivers/mfd/intel_quark_i2c_gpio.c
> >>> @@ -72,6 +72,10 @@ static const struct i2c_mode_info
> >>> platform_i2c_mode_info[] = {
> >>>  		.name = "GalileoGen2",
> >>>  		.i2c_scl_freq = 400000,
> >>>  	},
> >>> +	{
> >>> +		.name = "SIMATIC IOT2000",
> >>> +		.i2c_scl_freq = 400000,
> >>> +	},
> >>>  	{}
> >>>  };
> >>>  
> >>
> > 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog