Re: [PATCH RFC] perf/callchain: fixup charset file header

From: Peter Zijlstra
Date: Mon May 22 2017 - 08:52:41 EST


On Sat, May 20, 2017 at 06:47:31PM +0200, Nicholas Mc Guire wrote:
> Non-UTF-8 characters are a problem for some terminals and also
> make greping harder than necessary - this only switches the
> copyright sign to the common (C).
>
> Reported-by: Markus Kreidl <mkreidl@xxxxxxxxxxx>
> Signed-off-by: Nicholas Mc Guire <der.herr@xxxxxxx>
> ---
>
> Found by checkpatch --strict:
> CHECK: Invalid UTF-8, patch and commit message should be encoded in UTF-8
> #7: FILE: kernel/events/callchain.c:7:
> + * Copyright ? 2009 Paul Mackerras, IBM Corp. <paulus@xxxxxxxxxxx>
>
> Before I start generating sets of patches that fix encoding issues
> I would like to know if that is going to be accepted at all - the
> background is that it causes quite a bit of trouble when automating
> tools if these encoding problems make using simple tools hard (e.g.
> grep) and thus make automation a lot more complicated that necessary.
> It seems to me that the codingstyle does not mandate UTF-8 but there
> are a few places where it is "suggested" like in:
> Documentation/process/email-clients.rst

The last discussion on the subject was:

http://lkml.iu.edu/hypermail/linux/kernel/1001.2/02928.html

Which seemed to suggest replacing it with the UTF8 equivalent glyph. I
can't remember a patch, not Paul Ack'ing it (which is very much required
in order to change his copyright message).