Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

[Lyude Paul]

On Sat, 2017-05-20 at 13:39 +0200, Christian KÃnig wrote:
> Am 20.05.2017 um 01:48 schrieb Lyude:
> > This is the first part of me going through and cleaning up the IRQ
> > handling
> > code for radeon, since after taking a look at it the other day
> > while trying to
> > debug something I realized basically all of the code was copy
> > pasted
> > everywhere, and quite difficult to actually read through.
> > 
> > Will come up with something for r600 and cik once I've got the
> > chipsets on hand
> > to test with.
> > 
> > Lyude (3):
> > ÂÂÂdrm/radeon: Cleanup display interrupt handling for evergreen, si
> > ÂÂÂdrm/radeon: Cleanup HDMI audio interrupt handling for evergreen
> > ÂÂÂdrm/radeon: Cleanup pageflipping IRQ handling for evergreen, si
> 
> I don't have time to do a line by line review, but what I saw lookedÂ
> very good to me.
> 
> So the whole seres is Acked-by: Christian KÃnig <christian.koenig@amd
> .com>.
> 
> BTW: You don't want to take a look at the other hw generations as
> well?
Oh don't worry, I'm already planning on that! The next chance I have
available I'll be going my coworker's GPUs so I can get the hardware I
need to test refactors I write of the rest of the hw gen's IRQ handling
code. :)
> 
> Regards,
> Christian.
> 
> > 
> > Â drivers/gpu/drm/radeon/evergreen.cÂÂÂÂÂÂ| 943 ++++++-------------
> > -------------
> > Â drivers/gpu/drm/radeon/radeon.hÂÂÂÂÂÂÂÂÂ|ÂÂ27 +-
> > Â drivers/gpu/drm/radeon/radeon_irq_kms.c |ÂÂ35 ++
> > Â drivers/gpu/drm/radeon/si.cÂÂÂÂÂÂÂÂÂÂÂÂÂ| 655 +++++------------
> > -----
> > Â 4 files changed, 344 insertions(+), 1316 deletions(-)
> > 
> 
>