Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions

[Andy Shevchenko]

On Mon, May 22, 2017 at 5:32 PM, Luis Oliveira
<Luis.Oliveira@xxxxxxxxxxxx> wrote:
> On 08-May-17 17:53, Andy Shevchenko wrote:
>> On Mon, 2017-05-08 at 11:37 +0100, Luis Oliveira wrote:

>>> +            enabled, slave_activity, raw_stat, stat);
>>> +
>>
>>> +    if (slave_activity) {
>>> +            if (stat & DW_IC_INTR_RD_REQ) {
>>
>> Looking into next condition (stat & DW_IC_INTR_RX_DONE) I would
>> exchange these lines
>>
>
> By order? I don't think I understood your point. Please elaborate a little more.

if (stat & DW_IC_INTR_RD_REQ) {
  if (slave_activity) {

And perhaps refactor function a bit.

-- 
With Best Regards,
Andy Shevchenko