Re: linux-next: build warning after merge of the drivers-x86 tree

From: Andy Shevchenko
Date: Mon May 22 2017 - 14:03:14 EST


On Sat, May 20, 2017 at 1:09 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
>> Hi Darren,
>>
>> After merging the drivers-x86 tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
>> static ssize_t touchpad_store(struct device *dev,
>> ^
>>
>> Introduced by commit
>>
>> 7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
>
> Thank you Stephen,
>
> Andy, you warned me about this and I had forgotten before I included it in next.
>
> Would you like to drop this change, or drop the touchpad_store function?

I would go with Arnd's patch if he respins one addressing my comment.

--
With Best Regards,
Andy Shevchenko