Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
From: Jan Kiszka
Date: Mon May 22 2017 - 14:47:41 EST
On 2017-05-22 20:37, Andy Shevchenko wrote:
> On Mon, May 22, 2017 at 9:23 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>> On Mon, 22 May 2017, Andy Shevchenko wrote:
>>> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
>>>> On 2017-05-22 19:36, Andy Shevchenko wrote:
>
>>>> Then let's leave the decision up to the maintainer.
>>>
>>> Lee, just for your convenience I'm repeating myself here:
>>>
>>> I do not like this series at all since it tries to solve non-existing
>>> issue in over-engineering way.
>>>
>>> If you on opposite side I will be happy to help reviewing it.
>>
>> New code looks cleaner and appears to use an already defined API.
>
> Got your point.
> Jan, care to resend (an updated?) version?
>
Updated in which regard? The one for stmmac is broken, this one should
be fine.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux