Re: [PATCH 4/4] input: tsc2007: move header file out of I2C realm

From: Dmitry Torokhov
Date: Mon May 22 2017 - 16:54:34 EST


On Mon, May 22, 2017 at 08:41:05AM +0100, Lee Jones wrote:
> On Sun, 21 May 2017, Wolfram Sang wrote:
>
> > include/linux/i2c is not for client devices. Move the header file to a
> > more appropriate location.
> >
> > Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> > ---
> > arch/sh/boards/mach-ecovec24/setup.c | 2 +-
> > drivers/input/touchscreen/tsc2007_core.c | 2 +-
> > drivers/mfd/timberdale.c | 2 +-
>
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> > include/linux/{i2c => input}/tsc2007.h | 2 +-
> > 4 files changed, 4 insertions(+), 4 deletions(-)
> > rename include/linux/{i2c => input}/tsc2007.h (95%)

This should really go into include/linux/platform_data/, not into
input/, for the same reason you are moving it out of i2c. I'd also like
to get rid of platform data for tsc2007 altogether...

I guess I'll take it (moving to platform_data/) so I can work on generic
properties...

Thanks.

--
Dmitry