Re: [PATCH 1/2] misc: apds990x: move header file out of I2C realm

From: Linus Walleij
Date: Mon May 22 2017 - 18:33:47 EST


On Mon, May 22, 2017 at 11:49 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Mon, May 22, 2017 at 5:56 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>>
>>> Should we also remove the drivers or move them into staging?
>>
>> I'd prefer to keep them. If they are needed again, DT conversion is
>> likely and easier than restarting from scratch. Guenter Roeck also
>> prefers to not unnecessarily annoy people who might have out-of-tree
>> board code. So, as long as they are not painful, let's keep them?
>
> The one reason I can think of for removing them is that we don't
> want ambient light sensor drivers in drivers/misc any more and
> instead of adding DT probing code would also expect new users to
> migrate to drivers/iio/light/, which already has drivers for
> apds9300 and apds9960 but not apds990x, as well as bh1750 and
> bh1780 but not bh1770.

This (apds990x) and bh1770 were added by Samu Onkalo
for Nokia's upstreaming efforts.

Samu, what are the hardware targets using this? Something that
has a userspace etc that we can test?

Like Nokia 900 or so?

Yours,
Linus Walleij