Re: [PATCH 0/5] atm: Adjustments for some function implementations

From: Kees Cook
Date: Tue May 23 2017 - 00:32:40 EST


On Sun, May 21, 2017 at 1:12 PM, SF Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sun, 21 May 2017 22:09:11 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (5):
> Improve a size determination in four functions
> Delete an error message for a failed memory allocation in make_entry()
> Adjust 19 checks for null pointers
> Use seq_puts() in lec_info()
> Use seq_putc() in lec_info()
>
> net/atm/lec.c | 55 +++++++++++++++++++++++++++----------------------------
> 1 file changed, 27 insertions(+), 28 deletions(-)

These all look fine to me. Thanks!

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

-Kees

--
Kees Cook
Pixel Security