Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660

[zhangfei]

On 2017å05æ23æ 13:55, zhangfei wrote:
> Hi, Rob
>
>
> Thanks for the review.
>
> On 2017å05æ23æ 08:39, Rob Herring wrote:
> > On Wed, May 17, 2017 at 04:37:38PM +0800, Guodong Xu wrote:
> > > From: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
> > >
> > > Add I2C nodes for Hi3660-hikey960.
> > >
> > > On HiKey960,
> > > I2C0, I2C7 is connected to Low Speed Expansion Connector.
> > > I2C1 is connected to ADV7535.
> > > I2C3 is connected to USB5734.
> > >
> > > Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
> > > Signed-off-by: Guodong Xu <guodong.xu@xxxxxxxxxx>
> > > ---
> > >   arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 18 ++++++++
> > >   arch/arm64/boot/dts/hisilicon/hi3660.dtsi         | 56 
> > > +++++++++++++++++++++++
> > >   2 files changed, 74 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts 
> > > b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> > > index 64875a5..f685b1e 100644
> > > --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> > > +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> > > @@ -29,6 +29,24 @@
> > >       };
> > >   };
> > >   +&i2c0 {
> > > +    status = "okay";
> > > +};
> > > +
> > > +&i2c1 {
> > > +    status = "okay";
> > > +
> > > +    adv7533: adv7533@39 {
> > > +        status = "ok";
> > > +        compatible = "adi,adv7533";
> > > +        reg = <0x39>;
> > > +    };
> > > +};
> > > +
> > > +&i2c7 {
> > > +    status = "okay";
> > > +};
> > labels for the LS connector?

Do you mean arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi

                i2c@78ba000 {
                /* On Low speed expansion */
                        label = "LS-I2C1";
                        status = "okay";
                };

                spi@78b7000 {
                /* On High speed expansion */
                        label = "HS-SPI1";
                        status = "okay";
                };

Thanks
> > > +            compatible = "snps,designware-i2c";
> > These should have an SoC specific compatible.
> We directly use drivers/i2c/busses/i2c-designware-platdrv.c,
> do we still an soc specific compatible?
> Checked arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi, and other examples,
>
> compatible = "snps,designware-i2c" is used.
>
>
> Thanks