Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq

From: Lee Jones
Date: Tue May 23 2017 - 03:26:25 EST


On Tue, 23 May 2017, Zhang Rui wrote:

> On Fri, 2017-04-14 at 16:25 -0700,
> sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx wrote:
> > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxx
> > tel.com>
> >
> > PMIC mfd driver only exports first level irq for thermal device.
> > But currently we are reading the irqs from the second level irq
> > chip, So this patch fixes this issue by adding support to use
> > first level PMIC thermal irq.
> >
> > Signed-off-by: Kuppuswamy Sathyanarayanan
> > <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
>
> Acked-by: Zhang Rui <rui.zhang@xxxxxxxxx>

I think this is the last Ack.

Please collect them all and re-submit the set so I can pick it up.

> > ---
> > Âdrivers/thermal/intel_bxt_pmic_thermal.c | 2 +-
> > Â1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Changes since v1:
> > Â* None
> >
> > diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c
> > b/drivers/thermal/intel_bxt_pmic_thermal.c
> > index 0f19a39..ef6b322 100644
> > --- a/drivers/thermal/intel_bxt_pmic_thermal.c
> > +++ b/drivers/thermal/intel_bxt_pmic_thermal.c
> > @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct
> > platform_device *pdev)
> > Â }
> > Â
> > Â regmap = pmic->regmap;
> > - regmap_irq_chip = pmic->irq_chip_data_level2;
> > + regmap_irq_chip = pmic->irq_chip_data;
> > Â
> > Â pmic_irq_count = 0;
> > Â while ((irq = platform_get_irq(pdev, pmic_irq_count)) !=
> > -ENXIO) {

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog