Re: [PATCH] mm/oom_kill: count global and memory cgroup oom kills

From: David Rientjes
Date: Tue May 23 2017 - 03:50:28 EST


On Mon, 22 May 2017, Konstantin Khlebnikov wrote:

> Nope, they are different. I think we should rephase documentation somehow
>
> low - count of reclaims below low level
> high - count of post-allocation reclaims above high level
> max - count of direct reclaims
> oom - count of failed direct reclaims
> oom_kill - count of oom killer invocations and killed processes
>

In our kernel, we've maintained counts of oom kills per memcg for years as
part of memory.oom_control for memcg v1, but we've also found it helpful
to complement that with another count that specifies the number of
processes oom killed that were attached to that exact memcg.

In your patch, oom_kill in memory.oom_control specifies that number of oom
events that resulted in an oom kill of a process from that hierarchy, but
not the number of processes killed from a specific memcg (the difference
between oc->memcg and mem_cgroup_from_task(victim)). Not sure if you
would also find it helpful.