Re: [PATCH 0/2] perf stat: fix segfault when closing events

From: Mark Rutland
Date: Tue May 23 2017 - 06:05:33 EST


Hi,

Does anyone have any comments on these?

I'm happy to rebase/resend if necessary.

I'd very much like to see this fixed.

Thanks,
Mark.

On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote:
> Hi,
>
> These patches fix a segfault seen in some cases when perf stat is exiting.
>
> We don't balance opening/closing of events in all cases, and go out-of-bounds
> when we close events. Full details in the patch 2 commit message.
>
> Thanks,
> Mark.
>
> Mark Rutland (2):
> perf evsel: add per{cpu,thread} close helpers
> perf stat: balance opening/closing of events
>
> tools/perf/builtin-stat.c | 24 +++++++++++++++++++++++-
> tools/perf/util/evsel.c | 26 ++++++++++++++++++++------
> tools/perf/util/evsel.h | 4 ++++
> 3 files changed, 47 insertions(+), 7 deletions(-)
>
> --
> 1.9.1
>