Re: [PATCH v5 0/2] drm: Introduce writeback connectors

[Liviu Dudau]

On Tue, May 23, 2017 at 04:33:55PM +0200, Boris Brezillon wrote:
> Hi Liviu,

Hi Boris,

> 
> On Mon, 15 May 2017 18:20:55 +0100
> Liviu Dudau <Liviu.Dudau@xxxxxxx> wrote:
> 
> > Hi,
> > 
> > This is v5 of the writeback connector series. Boris Brezillon thought
> > that having to explicitly instantiate an encoder when using drm_writeback_connector
> > is a bit too cumbersome, so I'm pushing out this version where we embed
> > a virtual encoder inside drm_writeback_connector in order to satisfy the
> > DRM framework. The caller of drm_writeback_connector_init() can control
> > the embedded encoder by passing the drm_encoder_helper_funcs to be used.
> > 
> > Comments are welcome on the suitability of this series.
> 
> Whole series is:
> 
> Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> Tested-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> 
> Note that I tested it with the kms_writeback igt tests (available in
> your branch [1]).

Thanks a lot! Now that you seem to be happy with the series (right?) I'll
try to push the kms_writeback tests into igt and get this series accepted.

Best regards,
Liviu

> 
> I'll post the VC4 changes soon.
> 
> Thanks,
> 
> Boris
> 
> > 
> > Best regards,
> > Liviu
> > 
> > Brian Starkey (2):
> >   drm: Add writeback connector type
> >   drm: writeback: Add out-fences for writeback connectors
> > 
> >  Documentation/gpu/drm-kms.rst       |   9 +
> >  drivers/gpu/drm/Makefile            |   2 +-
> >  drivers/gpu/drm/drm_atomic.c        | 229 ++++++++++++++++++++++-
> >  drivers/gpu/drm/drm_atomic_helper.c |   6 +
> >  drivers/gpu/drm/drm_connector.c     |   4 +-
> >  drivers/gpu/drm/drm_writeback.c     | 362 ++++++++++++++++++++++++++++++++++++
> >  include/drm/drm_atomic.h            |  11 ++
> >  include/drm/drm_connector.h         |  13 ++
> >  include/drm/drm_mode_config.h       |  22 +++
> >  include/drm/drm_writeback.h         | 127 +++++++++++++
> >  include/uapi/drm/drm_mode.h         |   1 +
> >  11 files changed, 775 insertions(+), 11 deletions(-)
> >  create mode 100644 drivers/gpu/drm/drm_writeback.c
> >  create mode 100644 include/drm/drm_writeback.h
> > 
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    Â\_(ã)_/Â