Re: [linux-sunxi] [PATCH v6 9/9] arm64: allwinner: a64: enable Wi-Fi for Pine64

[Maxime Ripard]

On Fri, May 19, 2017 at 03:22:28PM +0800, icenowy@xxxxxxx wrote:
> å 2017-05-19 15:19ïMaxime Ripard åéï
> > On Fri, May 19, 2017 at 11:03:33AM +0800, Icenowy Zheng wrote:
> > > >The patch looks OK, but given the module is removable, I think it
> > > >should be
> > > >an overlay. The overlay would enable WiFi + Bluetooth, and all the
> > > >peripherals needed to connect them.
> > > >
> > > >That way, if the module is not installed, we avoid confusing the user
> > > >with
> > > >unused peripherals, and avoid having live voltage on an unoccupied
> > > >header.
> > > 
> > > But as this header have specific usage, we will also confuse user
> > > if it's not enabled as its target usage.
> > 
> > Yet you would enable unused resources.
> > 
> > This was already pointed out here:
> > https://patchwork.kernel.org/patch/9670235/
> 
> I think, before we have an official repository of device tree
> overlays (either directly in torvalds/linux or maintained by
> linux-sunxi), we shouldn't rely on device tree overlay
> functionality.

This is a board specific overlay, and having some upstream repository
with all the possible combinations of SoC / daughter board is just not
realistic.

This should be shipped by the board vendors. RPi does that, the
beaglebone does that, the CHIP does that, surely, if it works for
them, it should work for you.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature