Re: [PATCH 0/5] kernfs: add exportfs operations
From: Shaohua Li
Date: Tue May 23 2017 - 11:14:17 EST
On Tue, May 23, 2017 at 12:39:41AM -0700, Christoph Hellwig wrote:
> On Mon, May 22, 2017 at 03:53:04PM -0700, Shaohua Li wrote:
> > Hi,
> >
> > The goal isn't to export kernfs to NFS. The intention is to make tracing cgroup
> > aware. To do this, tracing will record an id for cgroup and use the id to find
> > cgroup name later. The best id is the cgroup directory inode number. Further to
> > filter out stale cgroup directory, fhandle is the best to identify a cgroup. So
> > this is what this series try to do.
>
> Eww. Even if you need to maintain i_generation for that please don't
> add the full export_operations. People will just get stupid ideas based
> on that.
Hi Christoph,
what did you mean 'don't add the full export_operations'? I'd love to change
this if there is better identification for a cgroup other than fhandle.
Thanks,
Shaohua