Re: [PATCH 3/5] clk: mvebu: ap806: introduce a new binding

From: Rob Herring
Date: Tue May 23 2017 - 11:26:27 EST


On Fri, May 19, 2017 at 05:58:03PM +0200, Gregory CLEMENT wrote:
> As for cp110, the initial intent when the binding of the ap806 system
> controller was to have one flat node. The idea being that what is
> currently a clock-only driver in drivers would become a MFD driver,
> exposing the clock, GPIO and pinctrl functionality. However, after taking
> a step back, this would lead to a messy binding. Indeed, a single node
> would be a GPIO controller, clock controller, pinmux controller, and
> more.
>
> This patch adopts a more classical solution of a top-level syscon node
> with sub-nodes for the individual devices. The main benefit will be to
> have each functional block associated to its own sub-node where we can
> put its own properties.
>
> The introduction of the Armada 7K/8K is still in the early stage so the
> plan is to remove the old binding. However, we don't want to break the
> device tree compatibility for the few devices already in the field. For
> this we still keep the support of the legacy compatible string with a big
> warning in the kernel about updating the device tree.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt | 20 +++++++++++++++-----
> drivers/clk/mvebu/ap806-system-controller.c | 56 ++++++++++++++++++++++++++++++++++++++++++++------------
> 2 files changed, 59 insertions(+), 17 deletions(-)

Acked-by: Rob Herring <robh@xxxxxxxxxx>