Re: [PATCH 1/2] mtd: nand: add generic helpers to check, match, maximize ECC settings

[Masahiro Yamada]

Hi Boris,

2017-05-18 16:09 GMT+09:00 Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>:

>>
>> One question about this part.
>>
>>
>>        /* If chip->ecc.size is already set, respect it. */
>>        if (chip->ecc.size && step_size != chip->ecc.size)
>>                continue;
>>
>> Does this make sense for nand_try_to_maximize_ecc()?
>>
>> (In other words, can nand-ecc-maximize stand together with nand-ecc-step-size?)
>
> It could make sense if one wants to maximize the strength for a
> specific step-size, but most of the time the user will let the driver
> choose the best step-size+strength pair.


OK.  I am keeping it here, but I do not have a strong opinion about this.
I will follow your decision.

Thanks.

-- 
Best Regards
Masahiro Yamada