Re: [PATCH 5/5] pinctrl: meson-gxl: Add Ethernet PHY LEDS pins

[Jerome Brunet]

On Wed, 2017-05-24 at 10:20 +0200, Neil Armstrong wrote:
> The Amlogic Meson GXL SoCs embeds an 10/100 Ethernet PHY, this patchs enables
> the Link and Activity LEDs signals.

Reviewed-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>

> 
> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> ---
> Âdrivers/pinctrl/meson/pinctrl-meson-gxl.c | 10 ++++++++++
> Â1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> index 7d81287..78a9af5 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> @@ -239,6 +239,9 @@
> Â
> Âstatic const unsigned int spdif_out_h_pins[]	= { PIN(GPIOH_4, EE_OFF)
> };
> Â
> +static const unsigned int eth_link_led_pins[]	= { PIN(GPIOZ_14,
> EE_OFF) };
> +static const unsigned int eth_act_led_pins[]	= { PIN(GPIOZ_15, EE_OFF)
> };
> +
> Âstatic const struct pinctrl_pin_desc meson_gxl_aobus_pins[] = {
> Â	MESON_PIN(GPIOAO_0, 0),
> Â	MESON_PIN(GPIOAO_1, 0),
> @@ -437,6 +440,8 @@
> Â	GROUP(i2s_out_ch23_z,	3,	26),
> Â	GROUP(i2s_out_ch45_z,	3,	25),
> Â	GROUP(i2s_out_ch67_z,	3,	24),
> +	GROUP(eth_link_led,	4,	25),
> +	GROUP(eth_act_led,	4,	24),
> Â
> Â	/* Bank H */
> Â	GROUP(hdmi_hpd,		6,	31),
> @@ -665,6 +670,10 @@
> Â	"spdif_out_h",
> Â};
> Â
> +static const char * const eth_led_groups[] = {
> +	"eth_link_led", "eth_act_led",
> +};
> +
> Âstatic const char * const gpio_aobus_groups[] = {
> Â	"GPIOAO_0", "GPIOAO_1", "GPIOAO_2", "GPIOAO_3", "GPIOAO_4",
> Â	"GPIOAO_5", "GPIOAO_6", "GPIOAO_7", "GPIOAO_8", "GPIOAO_9",
> @@ -736,6 +745,7 @@
> Â	FUNCTION(hdmi_i2c),
> Â	FUNCTION(i2s_out),
> Â	FUNCTION(spdif_out),
> +	FUNCTION(eth_led),
> Â};
> Â
> Âstatic struct meson_pmx_func meson_gxl_aobus_functions[] = {