Re: [PATCH 3/7] perf report: create real callchain entries for inlined frames

From: Milian Wolff
Date: Wed May 24 2017 - 07:42:24 EST


On Monday, May 22, 2017 2:19:46 PM CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:07PM +0200, Milian Wolff wrote:
> > +
> > + if (strcmp(funcname, base_sym->name) == 0) {
> > + // reuse the real, existing symbol
>
> I don't know whether it's required by coding style guide but please
> use C-style block comment if possible (especially for multiline comments).

OK. Since the patch check script didn't complain I thought it was OK to use
this style here.

I'll update the patch series accordingly.

Thanks

--
Milian Wolff | milian.wolff@xxxxxxxx | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

Attachment: smime.p7s
Description: S/MIME cryptographic signature