Re: [RFC PATCH 1/2] mm, memory_hotplug: drop artificial restriction on online/offline

[Michal Hocko]

On Wed 24-05-17 14:44:34, Vlastimil Babka wrote:
> On 05/24/2017 02:24 PM, Michal Hocko wrote:
> > From: Michal Hocko <mhocko@xxxxxxxx>
> > 
> > 74d42d8fe146 ("memory_hotplug: ensure every online node has NORMAL
> > memory") has added can_offline_normal which checks the amount of
> > memory in !movable zones as long as CONFIG_MOVABLE_NODE is disable.
> > It disallows to offline memory if there is nothing left with a
> > justification that "memory-management acts bad when we have nodes which
> > is online but don't have any normal memory".
> > 
> > 74d42d8fe146 ("memory_hotplug: ensure every online node has NORMAL
> > memory")
> 
> That's the same commit as above... one of them should be different?

This used to be two different patches which I decided to fold together
and I didn't realize that both online and offline paths were introduced
by the same patch.
[...]
> Some editing issue?

yes result of merging two commits.

> Otherwise makes sense to me.
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>

Thanks! Updated version follows
---