Re: [PATCH v2] clk: mvebu: add support for 1866MHz variants

[Gregory CLEMENT]

Hi Ralph,
 
 On mar., mai 23 2017, Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx> wrote:

Adding a word about the fact this patch is for the armada 38x SoC in the
title would be nice.

> The Linksys WRT3200ACM CPU is clocked at 1866MHz. Add 1866MHz to the
> list of supported CPU frequencies. Also update multiplier and divisor
> for the l2clk and ddrclk.
>
> Noticed by the following warning:
> [    0.000000] Selected CPU frequency (16) unsupported

I checked your values with the hardware datasheet and they match the
documentation:

Reviewed-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>

Thanks,

Gregory


>
> Signed-off-by: Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx>
> ---
>
> Hi everyone,
>
> This patch was part of a series adding support for the Linksys WRT3200ACM which
> got mostly merged already. So this one comes as a stand-alone patch intended
> for 4.13.
>
> Thanks
> Ralph
> ---
>
> Changes since v1:
>
>   - Update multipliers for and divisors for l2clk and ddrclk
> ---
>  drivers/clk/mvebu/armada-38x.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/mvebu/armada-38x.c b/drivers/clk/mvebu/armada-38x.c
> index 8bccf4e..394aa6f 100644
> --- a/drivers/clk/mvebu/armada-38x.c
> +++ b/drivers/clk/mvebu/armada-38x.c
> @@ -49,7 +49,8 @@ static const u32 armada_38x_cpu_frequencies[] __initconst = {
>  	0, 0, 0, 0,
>  	1066 * 1000 * 1000, 0, 0, 0,
>  	1332 * 1000 * 1000, 0, 0, 0,
> -	1600 * 1000 * 1000,
> +	1600 * 1000 * 1000, 0, 0, 0,
> +	1866 * 1000 * 1000,
>  };
>  
>  static u32 __init armada_38x_get_cpu_freq(void __iomem *sar)
> @@ -79,7 +80,7 @@ static const int armada_38x_cpu_l2_ratios[32][2] __initconst = {
>  	{1, 2}, {0, 1}, {0, 1}, {0, 1},
>  	{1, 2}, {0, 1}, {0, 1}, {0, 1},
>  	{1, 2}, {0, 1}, {0, 1}, {0, 1},
> -	{0, 1}, {0, 1}, {0, 1}, {0, 1},
> +	{1, 2}, {0, 1}, {0, 1}, {0, 1},
>  	{0, 1}, {0, 1}, {0, 1}, {0, 1},
>  	{0, 1}, {0, 1}, {0, 1}, {0, 1},
>  	{0, 1}, {0, 1}, {0, 1}, {0, 1},
> @@ -90,7 +91,7 @@ static const int armada_38x_cpu_ddr_ratios[32][2] __initconst = {
>  	{1, 2}, {0, 1}, {0, 1}, {0, 1},
>  	{1, 2}, {0, 1}, {0, 1}, {0, 1},
>  	{1, 2}, {0, 1}, {0, 1}, {0, 1},
> -	{0, 1}, {0, 1}, {0, 1}, {0, 1},
> +	{1, 2}, {0, 1}, {0, 1}, {0, 1},
>  	{0, 1}, {0, 1}, {0, 1}, {0, 1},
>  	{0, 1}, {0, 1}, {0, 1}, {0, 1},
>  	{0, 1}, {0, 1}, {0, 1}, {0, 1},
> -- 
> 2.10.2
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com