Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device

[Bart Van Assche]

On Tue, 2017-05-23 at 16:50 +0200, Johannes Thumshirn wrote:
> When pci_enable_device() or pci_enable_device_mem() fail in
> qla2x00_probe_one() we bail out but do a call to
> pci_disable_device(). This causes the dev_WARN_ON() in
> pci_disable_device() to trigger, as the device wasn't enabled
> previously.
> 
> So instead of taking the 'probe_out' error path we can directly return
> *iff* one of the pci_enable_device() calls fails.
> 
> Additionally rename the 'probe_out' goto label's name to the more
> descriptive 'disable_device'.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
> Fixes: e315cd28b9ef ("[SCSI] qla2xxx: Code changes for qla data structure refactoring")

Hello Johannes,

Please consider adding a Cc: stable tag to this patch. Since otherwise this
patch looks fine to me:

Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>