Re: [PATCH 1/8] firmware: vpd: do not leave freed section attributes to the list

[Guenter Roeck]

On Tue, May 23, 2017 at 5:07 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> We should only add section attribute to the list of section attributes
> if we successfully created corresponding sysfs attribute.
>
> Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Reviewed-by: Guenter Roeck <groeck@xxxxxxxxxxxx>

> ---
>  drivers/firmware/google/vpd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
> index 1e7860f02f4f..23a24a6d02c2 100644
> --- a/drivers/firmware/google/vpd.c
> +++ b/drivers/firmware/google/vpd.c
> @@ -136,12 +136,12 @@ static int vpd_section_attrib_add(const u8 *key, s32 key_len,
>         info->value = value;
>
>         INIT_LIST_HEAD(&info->list);
> -       list_add_tail(&info->list, &sec->attribs);
>
>         ret = sysfs_create_bin_file(sec->kobj, &info->bin_attr);
>         if (ret)
>                 goto free_info_key;
>
> +       list_add_tail(&info->list, &sec->attribs);
>         return 0;
>
>  free_info_key:
> --
> 2.13.0.219.gdb65acc882-goog
>