Re: [PATCH] powerpc/fadump: return error when fadump registration fails

From: kbuild test robot
Date: Thu May 25 2017 - 03:17:06 EST


Hi Michal,

[auto build test WARNING on powerpc/next]
[also build test WARNING on v4.12-rc2 next-20170525]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Michal-Suchanek/powerpc-fadump-return-error-when-fadump-registration-fails/20170525-083625
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc

All warnings (new ones prefixed by >>):

arch/powerpc/kernel/fadump.c: In function 'register_fadump':
>> arch/powerpc/kernel/fadump.c:978:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
return;
^~~~~~
arch/powerpc/kernel/fadump.c:968:12: note: declared here
static int register_fadump(void)
^~~~~~~~~~~~~~~

vim +/return +978 arch/powerpc/kernel/fadump.c

ebaeb5ae Mahesh Salgaonkar 2012-02-16 962 /* We will set the crashing cpu id in crash_fadump() during crash. */
ebaeb5ae Mahesh Salgaonkar 2012-02-16 963 fdh->crashing_cpu = CPU_UNKNOWN;
2df173d9 Mahesh Salgaonkar 2012-02-16 964
2df173d9 Mahesh Salgaonkar 2012-02-16 965 return addr;
2df173d9 Mahesh Salgaonkar 2012-02-16 966 }
2df173d9 Mahesh Salgaonkar 2012-02-16 967
c87372ca Michal Suchanek 2017-05-24 968 static int register_fadump(void)
3ccc00a7 Mahesh Salgaonkar 2012-02-20 969 {
2df173d9 Mahesh Salgaonkar 2012-02-16 970 unsigned long addr;
2df173d9 Mahesh Salgaonkar 2012-02-16 971 void *vaddr;
2df173d9 Mahesh Salgaonkar 2012-02-16 972
3ccc00a7 Mahesh Salgaonkar 2012-02-20 973 /*
3ccc00a7 Mahesh Salgaonkar 2012-02-20 974 * If no memory is reserved then we can not register for firmware-
3ccc00a7 Mahesh Salgaonkar 2012-02-20 975 * assisted dump.
3ccc00a7 Mahesh Salgaonkar 2012-02-20 976 */
3ccc00a7 Mahesh Salgaonkar 2012-02-20 977 if (!fw_dump.reserve_dump_area_size)
3ccc00a7 Mahesh Salgaonkar 2012-02-20 @978 return;
3ccc00a7 Mahesh Salgaonkar 2012-02-20 979
2df173d9 Mahesh Salgaonkar 2012-02-16 980 fadump_setup_crash_memory_ranges();
2df173d9 Mahesh Salgaonkar 2012-02-16 981
408cddd9 Hari Bathini 2014-10-01 982 addr = be64_to_cpu(fdm.rmr_region.destination_address) + be64_to_cpu(fdm.rmr_region.source_len);
2df173d9 Mahesh Salgaonkar 2012-02-16 983 /* Initialize fadump crash info header. */
2df173d9 Mahesh Salgaonkar 2012-02-16 984 addr = init_fadump_header(addr);
2df173d9 Mahesh Salgaonkar 2012-02-16 985 vaddr = __va(addr);
2df173d9 Mahesh Salgaonkar 2012-02-16 986

:::::: The code at line 978 was first introduced by commit
:::::: 3ccc00a7e04ff7718c9aebb4b0c982571c798759 fadump: Register for firmware assisted dump.

:::::: TO: Mahesh Salgaonkar <mahesh@xxxxxxxxxxxxxxxxxx>
:::::: CC: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip